search

cea-hpc / robinhood

Robinhood Policy Engine : a versatile tool to monitor filesystem contents and schedule actions on filesystem entries.
http://robinhood.sf.net
Other
177 stars 60 forks source link

lustre_tools.c: protect againt IOC_MDC_GETFILEINFO_V1 redefinition #138

Closed cedeyn closed 2 weeks ago

cedeyn commented 10 months ago

With lustre-2.15, IOC_MDC_GETFILEINFO_V1 is already declared in header file. This patch avoid compilation issue against more recent lustre version.

cedeyn commented 9 months ago

I was thinking defining something unique. Like RH_IOC_MDC_GETFILEINFO_V1 to avoid the repeat of name clash which happened when lustre used the same name. We deleted the whole section as we knew it was not the old version. However, this approach is good too.

It seems a patch already exists with the same idea :) https://review.gerrithub.io/c/cea-hpc/robinhood/+/541134

It should be merged soon.

arshad512 commented 9 months ago

I was thinking defining something unique. Like RH_IOC_MDC_GETFILEINFO_V1 to avoid the repeat of name clash which happened when lustre used the same name. We deleted the whole section as we knew it was not the old version. However, this approach is good too.

It seems a patch already exists with the same idea :) https://review.gerrithub.io/c/cea-hpc/robinhood/+/541134

It should be merged soon.

Thanks for letting me know. I agree with you. This is imporant and should be merged quickly.

tl-cea commented 2 weeks ago

Thank you for the contribution. A duplicate patch was landed to master: 7584c4f5ae058e0c7c322228bc8ee3c2fd375f1f