Closed degremont closed 4 years ago
Clean Shine code, removing all code features which are not compatible with Python 2.6+, in order to start supporting Python 3 in the future.
[x] except syntax (except Exception as exp)
except Exception as exp
[x] drop has_key()
has_key()
[x] Replace 'type(...) is' with isinstance()
[x] several methods now return an iterator instead of a list. This could easily trigger bugs, but hard to catch them.
[x] Use proper raise syntax for exceptions
Potential optimizations (not mandatory for Python 3)
First step is done in e151b96
I'm considering this ticket done. Let's have a dedicated ticket for Python 3 compat patches.
Clean Shine code, removing all code features which are not compatible with Python 2.6+, in order to start supporting Python 3 in the future.
[x] except syntax (
except Exception as exp
)[x] drop
has_key()
[x] Replace 'type(...) is' with isinstance()
[x] several methods now return an iterator instead of a list. This could easily trigger bugs, but hard to catch them.
[x] Use proper raise syntax for exceptions
Potential optimizations (not mandatory for Python 3)