search

cea-sec / sanzu

Graphical remote desktop solution
GNU General Public License v3.0
179 stars 27 forks source link

Some random drive-by changes and X11 things #167

Closed psychon closed 1 year ago

psychon commented 1 year ago

For $REASONS I came across this code base and took a look. This PR contains some random things that resulted from my look. Hopefully, each commit's description says what it does and gives a clear reason.

I would guess that the last commit is the most questionable: https://github.com/cea-sec/sanzu/commit/73bc009efe75ec1a2f37d74c1d82bcc653063ed5 If you want, I can remove this.

I came across the code for creating a cursor in the client (set_cursor) that wants to be able to set "nicer" cursors, but touching that seemed a bit too much for now. Hence, I did not implement that. Instead, here is a pointer for some inspiration (ignore the storage parameter and just pretend that it is always None; this is for re-using some things across a loop): https://github.com/psychon/x11rb/blob/883354bd79536e97941bda38b5d705cc5d974a93/x11rb/src/cursor/mod.rs#L217-L273

serpilliere commented 1 year ago

Hey @psychon : Thanks a lot for the great review, the hints, and the paches!