search

cealicea171 / more-css-practice

Recreating CSS Layouts
0 stars 0 forks source link

Semantics #1

Open jmorris-dev opened 6 years ago

jmorris-dev commented 6 years ago

https://github.com/cealicea171/more-css-practice/blob/53263a849d719d78c51cf004821317aa1358a731/airbnb/index.html#L10

Instead of using <div class="header"> and <div class="main"> you can use <header> and <main>. This is more semantic in html 5 and should help clean up your css.

Apply top: 0; width: 100%; to your header element and this should get rid of those black lines on the top and side.

zachfedor commented 6 years ago

Good call on the semantics, @jmorris1990 !

Although @cealicea171 may have made some changes after you submitted your issue, because I don't think your CSS fix will help. I don't see black lines on the top or side now...