search

ceaseless-prayer / CeaselessAndroid

This is the Android application code for Ceaseless.
http://ceaselessprayer.com/
MIT License
7 stars 3 forks source link

Issue86 enhancement add people favorite tab #101

Closed evandyang closed 6 years ago

evandyang commented 6 years ago

Added a Favorite tab to the People fragment.

chrislim commented 6 years ago

Please resolve the merge conflicts (e.g. https://github.com/ceaseless-prayer/CeaselessAndroid/pull/101/files#diff-ddb55b5f72909f0ea45dfeac0cdbc8b2R44)

evandyang commented 6 years ago

Addressed merge conflicts and also CI failure.

chrislim commented 6 years ago

Looks good, I'll merge this, but quick question: do you think we should have the favorite icon in the favorite list? I know you left it out and just wanted to know your thoughts on it.

Also, we need to update the localization files since you've added the new "Favorite" string.

evandyang commented 6 years ago

I left the Favorite icon out because I thought it was redundant to show the favorite icon in the Favorite tab. That being said, I could add the favorite icons if desired. I imagine seeing all those filled hearts would be nice :)