ceaseless-prayer / CeaselessIOS

This is the iOS application code for Ceaseless.
http://www.ceaselessprayer.com
MIT License
5 stars 2 forks source link

7 crashes in last 2 weeks on CFRelease of phoneNumbers? #204

Closed chrislim closed 7 years ago

chrislim commented 7 years ago

Got 7 crashes on this code: https://github.com/ceaseless-prayer/CeaselessIOS/blob/master/Ceaseless/CeaselessLocalContacts.m#L484

image

LIL717 commented 7 years ago

https://developer.apple.com/reference/corefoundation/1521153-cfrelease

"If cf is NULL, this will cause a runtime error and your application will crash."

Probably need to check if phoneNumbers is NULL before calling CFRelease.

chrislim commented 7 years ago

Waiting for app review, but this commit should fix it: 1220ff9