Remove skipped test checks for symfony/yaml bug

cebe / php-openapi

Read and write OpenAPI yaml/json files and make the content accessible in PHP objects.

MIT License

466 stars 87 forks source link

Remove skipped test checks for symfony/yaml bug #133

Closed cebe closed 2 years ago

cebe commented 2 years ago

Symfony bug https://github.com/symfony/symfony/issues/34805 seems to be fixed so we should be able to remove these checks:

https://github.com/cebe/php-openapi/blob/ba2f0cf7f9ea0721f6d4b8591943d26187c9c496/tests/ReaderTest.php#L97-L109

https://github.com/cebe/php-openapi/blob/ba2f0cf7f9ea0721f6d4b8591943d26187c9c496/tests/spec/OpenApiTest.php#L191-L205

polkabunny commented 2 years ago

Hi there, I can take a look if it's just removing the tests. Do they need to be replaced with anything?

cebe commented 2 years ago

sorry for the weird wording, this is not about removing the test itself but remove the check for the symfony version which skips the test in certain setups. So now the test should run in all cases.

TODO:

remove the check for symfony/yaml version, so that test always runs
check if it is green on all versions of symfony/yaml that we run tests against (see github action checks)
nothing to to if all is green
need to check what is wrong if tests are still failing.