search

cebe / php-openapi

Read and write OpenAPI yaml/json files and make the content accessible in PHP objects.
MIT License
466 stars 88 forks source link

Add support for Symfony/YAML 4.4 #61

Closed recchia closed 4 years ago

recchia commented 4 years ago

Add support for Symfony/YAML 4.4, this is a transition version to 5. In 4.4 you can fix/remove deprecated code before migrate to version 5

aberlinski commented 4 years ago

Hello @cebe

Could you please tell me when this pull request is going to be merged? We want to use cebe/php-openapi in our project, but lack of symfony/Yaml 4.4 support blocks us. I would be appreciate to merge it as quick as it possible :)

cebe commented 4 years ago

I was explicitly excluding this version because of bugs in the yaml implementation, see https://github.com/cebe/php-openapi/issues/60

If it does not break my tests I can add it back, need to check it.

cebe commented 4 years ago

updated composer.json, lets see if tests are green. Tests are running on 4.3 anyway so that should work.

cebe commented 4 years ago

https://travis-ci.org/github/cebe/php-openapi/builds/691798677

tests are fine, seems phpstan is broken...

cebe commented 4 years ago

Merged, Thank you!