search

cebe / php-openapi

Read and write OpenAPI yaml/json files and make the content accessible in PHP objects.
MIT License
466 stars 88 forks source link

Support PHP 8 #81

Closed canvural closed 3 years ago

canvural commented 3 years ago

Hello,

Are there any plans for adding support for PHP 8?

Today I checked what needs to be updated. All dependencies except php-cs-fixer have PHP 8 compatible versions. So the issues I found are:

  1. php-cs-fixer needs to updated. There is an issue about it there. Looks like it's still a work in progress. But as mentioned in the discussion here, it is not really a blocker. PHAR release can be downloaded and used in CI. Or something like https://github.com/bamarni/composer-bin-plugin

  2. Some PHPUnit methods used in tests are deprecated in newer versions. But that's easy to fix I guess.

What are your thoughts?

cebe commented 3 years ago

Are there any plans for adding support for PHP 8?

sure :)

canvural commented 3 years ago

Ok. So, looking forward to it :+1: