PHP8 support - Githubissues

cebe / php-openapi

Read and write OpenAPI yaml/json files and make the content accessible in PHP objects.

MIT License

466 stars 88 forks source link

PHP8 support #83

Closed canvural closed 3 years ago

canvural commented 3 years ago

This PR:

[x] Fixes #81
[x] Removes php-cs-fixer from composer.json and downloads phar on launch
[x] Fixes deprecated PHPUnit methods

cebe commented 3 years ago

Thanks for these changes. Tests are failing, seems there is another case related to assertInternalType() method. Do you have the time to fix these?

canvural commented 3 years ago

@cebe Updated the PR :+1: Locally tests are failing for ReferenceTest::testTransitiveReferenceOverTwoFiles But I'm thinking this is because of the latest changes to master?

cebe commented 3 years ago

Thank you! I'll check that.

cebe commented 3 years ago

whatever happened to travis, their open source tests are having a large backlog, can't check the tests for different systems this way :-/

canvural commented 3 years ago

Basically, travis-ci.org is shutting down soon. And now there will be no free builds for OSS projects. :man_shrugging: If I understood correctly.

cebe commented 3 years ago

seems like that, I'm implementing github actions right now.

cebe commented 3 years ago

Merged your changes, will clean up the build on master. Thank you!

canvural commented 3 years ago

Thank you @cebe

cebe commented 3 years ago

Tests are failing here due to a symfony bug :laughing: https://github.com/symfony/symfony/issues/39521