cebix / macemu

Basilisk II and SheepShaver Macintosh emulators
1.38k stars 288 forks source link

Port mini vMac guest OS screen ROM patch. #215

Closed rickyzhang82 closed 4 years ago

rickyzhang82 commented 4 years ago

See my screen cast demo here

Travis is great to catch my first PR. It detected that I haven't patched for SDL1 or XWindow.

See Travis indicated the build is green

I personally tested all 3 combinations and make sure this PR works.

Signed-off-by: Ricky Zhang rickyzhang@gmail.com

rickyzhang82 commented 4 years ago

@asvitkine

Thanks for your prompt response. After carefully reviewing in vim, I found what you are after in the comment style. It is too bad that Qt Creator doesn't visualize it properly.

I rejected your request of merging SDL1, SDL2, XWindows setting code. Because there are macro and unique codes in XWindows. But I will think about refactoring the common code between SDL1 and SDL2. There is no fun to write and maintain any duplicate code. Also, I believe there are dead code in SDL2 which requires some cleaning. But it will not be in this PR.