search

cebor / angular-highcharts

Highcharts directive for Angular
MIT License
212 stars 63 forks source link

Add support ESbuild imports #397

Open kirill-borisyonok opened 6 months ago

kirill-borisyonok commented 6 months ago

https://angular.dev/tools/cli/esbuild#esm-default-imports-vs-namespace-imports

My npm versions: "@angular/core": "17.1.2", "@angular-devkit/build-angular": "17.1.2", "angular-highcharts": "17.0.0",

Error: Unable to resolve specifier 'highcharts/highcharts-gantt' imported from http://localhost:4200/angular_highcharts-17_0_0-dev.js at throwUnresolved (es-module-shims.js:442:11) at _resolve (es-module-shims.js:399:71) at es-module-shims.js:848:32 at Array.map () at es-module-shims.js:844:45 at _ZoneDelegate.invoke (zone.js:368:26) at Zone2.run (zone.js:129:43) at zone.js:1257:36 at _ZoneDelegate.invokeTask (zone.js:402:31) at Zone2.runTask (zone.js:173:47)

andrei4ik1997 commented 6 months ago

I have same problem. @cebor pls fix it

cebor commented 6 months ago

Hello @kirill-borisyonok and @andrei4ik1997, im not sure what to do here. Before there was an issue with the highcharts lib, which did not allowed namespace imports. Don't know if they fixed this.

Currently i dont have a dev machiene to test this. Could you possibly start a PR? I also updateted highcharts to the latest version in the repo.

andrei4ik1997 commented 6 months ago

@cebor We also opened issue to Highcharts https://github.com/highcharts/highcharts/issues/20616

andrei4ik1997 commented 6 months ago

@cebor We can do this solution in library https://github.com/highcharts/highcharts/issues/20616#issuecomment-1945599576 ?Or are there other suggestions?