cecco974 / jsdoc-toolkit

Automatically exported from code.google.com/p/jsdoc-toolkit
0 stars 0 forks source link

folders with non-js files (even with the x option) causes exception #193

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
On behalf of  Remiya:

I am writing a shareware GUI for the js-doc-toolkit. And I found the following 
issue. If a folder 
is passed to the js-doc-toolkit, which contains files other than js (i.e jpg, 
ini, etc) an error is 
thrown and the application exits. Even if I specify the extension with the 
-ext=js options, it still 
throws the error.

So actually I made a little debugging and I found, that the the error occurs in 
the 
JSDOC.JsDoc._getSrcFiles function.

When I insert the following line in the file JsDoc.js the error is not thrown, 
and the JavaScript files 
get parsed properly:
var thisExt = $.split(".").pop().toLowerCase();
if(thisExt=="js"){return true;}else{return false;}

Original issue reported on code.google.com by micmath on 24 Jan 2009 at 9:39

GoogleCodeExporter commented 8 years ago
Fixed.
Committed revision 773.
Thank you for reporting this!

Original comment by micmath on 24 Jan 2009 at 9:42

GoogleCodeExporter commented 8 years ago
How do I get the version that contains this fix? I downloaded 
jsdoc_toolkit-2.1.0.zip
which is the "featured" download and appears to be the most updated version, 
but it
did not include this fix.

Original comment by RaineOrS...@gmail.com on 16 Mar 2009 at 8:42

GoogleCodeExporter commented 8 years ago
It hasn't been released yet. You would need to either generate a patch from the 
project Subversion repository, or 
check out the latest revision directly -- see the "source" tab on the main 
project page. If you don't have 
Subversion (or the will to use that sort of software -- I wouldn't blame you, 
believe me) Just let me know and I'll 
do a quick "bug-fix" release you can just download.

Original comment by micmath on 19 Mar 2009 at 9:56

GoogleCodeExporter commented 8 years ago
That makes sense. I can generate a patch then. Thanks for your help.

Original comment by RaineOrS...@gmail.com on 19 Mar 2009 at 2:14

GoogleCodeExporter commented 8 years ago
That makes sense. I can generate patch then. Thanks for your help.

Original comment by RaineOrS...@gmail.com on 19 Mar 2009 at 2:15