search

cech12 / CeramicBucket

Minecraft mod that adds a Ceramic Bucket
https://www.curseforge.com/minecraft/mc-mods/ceramic-bucket
MIT License
3 stars 4 forks source link

[1.19.2 Feature]: Blacklist liquids in a config file #72

Closed vizthex123 closed 1 year ago

vizthex123 commented 1 year ago

Describe the Feature

There's some fluids that only half-work with the bucket (so far, Cognitium from Experience Obelisk, so it'd be nice if modpack authors could blacklist them in a config file.

cech12 commented 1 year ago

Thanks for your report!

I thought about a possibility to deactivate fluids. But a better way to solve this issue could be to fix the fluid compatibility :)

Which part of the fluid does not work?

vizthex123 commented 1 year ago

Thanks for your report!

I thought about a possibility to deactivate fluids. But a better way to solve this issue could be to fix the fluid compatibility :)

Which part of the fluid does not work?

you can right-click to deposit it back into the Obelisk, but if you do so with a clay bucket it just places the block.

cech12 commented 1 year ago

note for me:

Experience Obelisk only supports its own buckets at right click behaviour. So, other mods with other fluid containers doesn't work for now.

master: https://github.com/terrarium-earth/Experience-Obelisk/blob/master/src/main/java/com/cyanogen/experienceobelisk/block/ExperienceObeliskBlock.java#L90

1.19.2: https://github.com/terrarium-earth/Experience-Obelisk/blob/content-expansion-1.19.2/src/main/java/com/cyanogen/experienceobelisk/block/ExperienceFountainBlock.java#L87 (open todo)

When I have time, I will open a PR to support other mods fluid containers.

vizthex123 commented 1 year ago

noice.

cech12 commented 1 year ago

I opened a PR for Experience Obelisk: https://github.com/terrarium-earth/Experience-Obelisk/pull/16

cech12 commented 1 year ago

@vizthex123 The Experience Obelisk is supported since experienceobelisk-v1.4.10 (1.20.1, 1.19.2, 1.18.2)

There is another issue https://github.com/cech12/BucketLib/issues/11 where the topic is continued. If you have any other fluids or mods that are having issues, please feel free to open an issue here at Github. :)

vizthex123 commented 12 months ago

@vizthex123 The Experience Obelisk is supported since experienceobelisk-v1.4.10 (1.20.1, 1.19.2, 1.18.2)

There is another issue cech12/BucketLib#11 where the topic is continued. If you have any other fluids or mods that are having issues, please feel free to open an issue here at Github. :)

noice, thanks.