search

cecilianor / Qt-thesis

MIT License
9 stars 4 forks source link

Bug report: The Protobuf handling function accepts completely empty mvt files? #53

Closed cecilianor closed 6 months ago

cecilianor commented 7 months ago

Nils and I are working on unit testing caching today.

While testing, we figured out that the function VectorTile::tileFromByteArray(...) doesn't stop/fail if the passed mvt file is empty. We should have an error check that stops the parsing if the file that contains the tile doesn't contain any data. It currently only stops the parsing if there is data in the file, and if the data is messed up.

Could we discuss this in an upcoming meeting with the team?

cecilianor commented 6 months ago

This isn't necessarily a bug. Sometimes the tiles are empty, like over water. The team discussed this problem a few weeks ago and have revised the code with no further action needing to be taken currently. Closing the issue now.