search

cecobask / imdb-trakt-sync

Automatic sync from IMDb to Trakt (watchlist, lists, ratings and history) using GitHub actions.
MIT License
97 stars 229 forks source link

fix 401 when getting auth codes #29

Closed SanderVanBeers closed 7 months ago

SanderVanBeers commented 7 months ago

The reason for the 401 in the POST https://api.trakt.tv/oauth/device/code is the Authorization header. Simply removing the header resolves the issue. Fixes #28

codecov-commenter commented 7 months ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

cecobask commented 7 months ago

Thanks a lot for your contribution, @SanderVanBeers!

Donostio commented 7 months ago

Please could someone help me - I believe I'm running this from a fork to my own repository but I can't work out how to pull through this change. I've been looking for a button to agree / pull through the change in my repository and on the pull request here. thanks for any help.

Do I need to set up Codecov?

SanderVanBeers commented 7 months ago

@Donostio In your forked repository you can press the "Sync fork" button. You will see the option to pull in the change.

image

Donostio commented 7 months ago

@Donostio In your forked repository you can press the "Sync fork" button. You will see the option to pull in the change.

image

Thank you so much @SanderVanBeers. I was looking in the 'pull requests' tab (dodgy advice from AI) and not the 'code' tab. I've sync'd them now but I'm getting: Process completed with exit code 1.

Code used was: name: sync on: push: branches:

Donostio commented 7 months ago

What am I doing wrong? Screenshot 2024-03-29 11 43 10

SanderVanBeers commented 7 months ago

@Donostio image It seems you haven't set up your environment secrets correctly.

They need to be set up as detailed in the readme. image

Donostio commented 7 months ago

That's weird. It was working before. I'll re-do the secrets. Thanks for the tip.

cecobask commented 7 months ago

There were recent breaking changes relating to secret naming. All you have to do is create them with the appropriate names and values (outlined in the README.md file), then it will work again.

Donostio commented 7 months ago

Thank you. Is IMDB_LIST_IDS no longer being used? I fixed the secrets but I'm now getting that error, ":"trakt rate limit reached". I think it might be because I have more lists on IMDB then my Trakt account limit and my IMDB_LIST_IDS has a selection of them,

cecobask commented 7 months ago

You can still target specific IMDb lists for syncing. Use the secret name IMDB_LISTS for that purpose. Its value must be a comma separated list of IDs. The trakt account limit exceeded error is encountered because you’ve reached the max number of Trakt lists, which you can overcome by defining the IMDB_LISTS secret.

Donostio commented 7 months ago

Thank you for the clarification. I left my previous working list secret in place (since the name hadn't changed). Do I need to update it?

On Sat, 30 Mar 2024, 06:18 Tsvetoslav Dimov, @.***> wrote:

You can still target specific IMDb lists for syncing. Use the secret name IMDB_LISTS for that purpose. Its value must be a comma separated list of IDs. The trakt account limit exceeded error is encountered because you’ve reached the max number of Trakt lists, which you can overcome by defining the IMDB_LISTS secret.

— Reply to this email directly, view it on GitHub https://github.com/cecobask/imdb-trakt-sync/pull/29#issuecomment-2027938946, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE35SWO5ETN6ZGEQS7LJ4ITY2ZKMFAVCNFSM6AAAAABFL3NEVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHEZTQOJUGY . You are receiving this because you were mentioned.Message ID: @.***>

cecobask commented 7 months ago

There is a difference. The new secret name is IMDB_LISTS and the old secret name is IMDB_LIST_IDS. Feel free to delete the old secret, it’s not used anymore in the latest version of the application.

Donostio commented 7 months ago

Ah, thanks. I didn't see the new name for list secret, must have missed it.

On Sat, 30 Mar 2024, 07:35 Tsvetoslav Dimov, @.***> wrote:

There is a difference. The new secret name is IMDB_LIST_IDS and the old secret name is IMDB_LISTS. Feel free to delete the old secret, it’s not used anymore in the latest version of the application.

— Reply to this email directly, view it on GitHub https://github.com/cecobask/imdb-trakt-sync/pull/29#issuecomment-2027954413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE35SWNQ77DNIFAL5CBWEWDY2ZTNFAVCNFSM6AAAAABFL3NEVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHE2TINBRGM . You are receiving this because you were mentioned.Message ID: @.***>

Donostio commented 7 months ago

hmmm... I just checked and I had updated to IMDB_LIST_IDS. It's still trying to import all lists though. Have I missed another setting to ensure that the List secret is used?

On Sat, 30 Mar 2024 at 07:42, Gary Shearin @.***> wrote:

Ah, thanks. I didn't see the new name for list secret, must have missed it.

On Sat, 30 Mar 2024, 07:35 Tsvetoslav Dimov, @.***> wrote:

There is a difference. The new secret name is IMDB_LIST_IDS and the old secret name is IMDB_LISTS. Feel free to delete the old secret, it’s not used anymore in the latest version of the application.

— Reply to this email directly, view it on GitHub https://github.com/cecobask/imdb-trakt-sync/pull/29#issuecomment-2027954413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE35SWNQ77DNIFAL5CBWEWDY2ZTNFAVCNFSM6AAAAABFL3NEVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHE2TINBRGM . You are receiving this because you were mentioned.Message ID: @.***>

Donostio commented 7 months ago

Error: failure hydrating trakt lists: failure creating trakt list amanda-only: http request POST https://api.trakt.tv/users/donostio/lists/ returned status code 420: trakt account limit exceeded, more info here: https://github.com/trakt/api-help/discussions/350 26 https://github.com/Donostio/imdb-trakt-sync/actions/runs/8488854529/job/23260212300#step:5:27 {"time":"2024-03-30T09:13:51.62202649Z","level":"ERROR","source":{"function":" github.com/cecobask/imdb-trakt-sync/pkg/syncer.(*Syncer).Sync","file":"/home/runner/work/imdb-trakt-sync/imdb-trakt-sync/pkg/syncer/syncer.go","line":67},"msg":"failure hydrating imdb client","error":"failure hydrating trakt lists: failure creating trakt list amanda-only: http request POST https://api.trakt.tv/users/donostio/lists/ returned status code 420: trakt account limit exceeded, more info here: https://github.com/trakt/api-help/discussions/350"} 27 https://github.com/Donostio/imdb-trakt-sync/actions/runs/8488854529/job/23260212300#step:5:28make: *** [Makefile:7: sync] Error 1 28 https://github.com/Donostio/imdb-trakt-sync/actions/runs/8488854529/job/23260212300#step:5:29Error: Process completed with exit code 2. 29 https://github.com/Donostio/imdb-trakt-sync/actions/runs/8488854529/job/23260212300#step:5:30##[debug]Finishing: Sync Kind regards Gary

On Sat, 30 Mar 2024 at 09:09, Gary Shearin @.***> wrote:

hmmm... I just checked and I had updated to IMDB_LIST_IDS. It's still trying to import all lists though. Have I missed another setting to ensure that the List secret is used?

On Sat, 30 Mar 2024 at 07:42, Gary Shearin @.***> wrote:

Ah, thanks. I didn't see the new name for list secret, must have missed it.

On Sat, 30 Mar 2024, 07:35 Tsvetoslav Dimov, @.***> wrote:

There is a difference. The new secret name is IMDB_LIST_IDS and the old secret name is IMDB_LISTS. Feel free to delete the old secret, it’s not used anymore in the latest version of the application.

— Reply to this email directly, view it on GitHub https://github.com/cecobask/imdb-trakt-sync/pull/29#issuecomment-2027954413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE35SWNQ77DNIFAL5CBWEWDY2ZTNFAVCNFSM6AAAAABFL3NEVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHE2TINBRGM . You are receiving this because you were mentioned.Message ID: @.***>

Donostio commented 7 months ago

Ok, progress!

I got it working by adding the old secret (IMDB_LISTS) back in. I left the new one (IMDB_LIST_IDS) in place too.

Could that mean that my fork isn't properly updating - if it's pointing at the old secret? Many thanks

On Sat, 30 Mar 2024 at 09:15, Gary Shearin @.***> wrote:

Error: failure hydrating trakt lists: failure creating trakt list amanda-only: http request POST https://api.trakt.tv/users/donostio/lists/ returned status code 420: trakt account limit exceeded, more info here: https://github.com/trakt/api-help/discussions/350 26 https://github.com/Donostio/imdb-trakt-sync/actions/runs/8488854529/job/23260212300#step:5:27 {"time":"2024-03-30T09:13:51.62202649Z","level":"ERROR","source":{"function":" github.com/cecobask/imdb-trakt-sync/pkg/syncer.(*Syncer).Sync","file":"/home/runner/work/imdb-trakt-sync/imdb-trakt-sync/pkg/syncer/syncer.go","line":67},"msg":"failure hydrating imdb client","error":"failure hydrating trakt lists: failure creating trakt list amanda-only: http request POST https://api.trakt.tv/users/donostio/lists/ returned status code 420: trakt account limit exceeded, more info here: https://github.com/trakt/api-help/discussions/350"} 27 https://github.com/Donostio/imdb-trakt-sync/actions/runs/8488854529/job/23260212300#step:5:28make: *** [Makefile:7: sync] Error 1 28 https://github.com/Donostio/imdb-trakt-sync/actions/runs/8488854529/job/23260212300#step:5:29Error: Process completed with exit code 2. 29 https://github.com/Donostio/imdb-trakt-sync/actions/runs/8488854529/job/23260212300#step:5:30##[debug]Finishing: Sync Kind regards Gary

On Sat, 30 Mar 2024 at 09:09, Gary Shearin @.***> wrote:

hmmm... I just checked and I had updated to IMDB_LIST_IDS. It's still trying to import all lists though. Have I missed another setting to ensure that the List secret is used?

On Sat, 30 Mar 2024 at 07:42, Gary Shearin @.***> wrote:

Ah, thanks. I didn't see the new name for list secret, must have missed it.

On Sat, 30 Mar 2024, 07:35 Tsvetoslav Dimov, @.***> wrote:

There is a difference. The new secret name is IMDB_LIST_IDS and the old secret name is IMDB_LISTS. Feel free to delete the old secret, it’s not used anymore in the latest version of the application.

— Reply to this email directly, view it on GitHub https://github.com/cecobask/imdb-trakt-sync/pull/29#issuecomment-2027954413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE35SWNQ77DNIFAL5CBWEWDY2ZTNFAVCNFSM6AAAAABFL3NEVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHE2TINBRGM . You are receiving this because you were mentioned.Message ID: @.***>

cecobask commented 7 months ago

Hi @Donostio! After sending my previous message here I accidentally exchanged the name for old and new secret. I promptly edited the message, not more than a couple minutes after sending. However, if you’re reading these messages from your email client, it will not show you the latest message updates. Hence why the confusion happened.

victorguizien commented 7 months ago

Updated the code with this update and still getting an error, this time with code 422

image

Secrets are set and updated. ¿any troubleshooting steps?

Thanks!