search

cecobask / imdb-trakt-sync

Automatic sync from IMDb to Trakt (watchlist, lists, ratings and history) using GitHub actions.
MIT License
97 stars 229 forks source link

refactor: remove imdb http client and clean up code #44

Closed cecobask closed 4 months ago

cecobask commented 4 months ago

Removed the reliance on the IMDb HTTP client. From now on username, user ID and watchlist ID will be scraped from the browser.

codecov-commenter commented 4 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 5.83333% with 113 lines in your changes missing coverage. Please review.

Project coverage is 45.37%. Comparing base (37f1af2) to head (94c6eed). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #44 +/- ## =========================================== - Coverage 92.45% 45.37% -47.09% =========================================== Files 5 14 +9 Lines 941 1457 +516 =========================================== - Hits 870 661 -209 - Misses 46 780 +734 + Partials 25 16 -9 ``` | [Files](https://app.codecov.io/gh/cecobask/imdb-trakt-sync/pull/44?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tsvetoslav+Dimov) | Coverage Δ | | |---|---|---| | [pkg/client/client.go](https://app.codecov.io/gh/cecobask/imdb-trakt-sync/pull/44?src=pr&el=tree&filepath=pkg%2Fclient%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tsvetoslav+Dimov#diff-cGtnL2NsaWVudC9jbGllbnQuZ28=) | `100.00% <100.00%> (ø)` | | | [pkg/client/trakt.go](https://app.codecov.io/gh/cecobask/imdb-trakt-sync/pull/44?src=pr&el=tree&filepath=pkg%2Fclient%2Ftrakt.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tsvetoslav+Dimov#diff-cGtnL2NsaWVudC90cmFrdC5nbw==) | `91.96% <100.00%> (-0.36%)` | :arrow_down: | | [internal/syncer/syncer.go](https://app.codecov.io/gh/cecobask/imdb-trakt-sync/pull/44?src=pr&el=tree&filepath=internal%2Fsyncer%2Fsyncer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tsvetoslav+Dimov#diff-aW50ZXJuYWwvc3luY2VyL3N5bmNlci5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/client/imdb.go](https://app.codecov.io/gh/cecobask/imdb-trakt-sync/pull/44?src=pr&el=tree&filepath=pkg%2Fclient%2Fimdb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tsvetoslav+Dimov#diff-cGtnL2NsaWVudC9pbWRiLmdv) | `0.00% <0.00%> (-91.53%)` | :arrow_down: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/cecobask/imdb-trakt-sync/pull/44/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tsvetoslav+Dimov)