search

cedadev / RAMIP

Repository Contains basic analysis codes for RAMIP experiments
Apache License 2.0
0 stars 0 forks source link

EC-Earth-Consortium ceda-cc report #4

Open mollymacrae opened 5 months ago

mollymacrae commented 5 months ago

The following error was raised from sampling the experiment ssp370 r5i1p1f1 2015-2020 data for EC-Earth-Consortium.

Incorrect activity_id For all files, the Global attribute activity_id is ''ScenarioMIP AerChemMIP' when it should be 'RAMIP' according to the tables. FAILED:: Global attributes do not match constraints: [('activity_id', 'ScenarioMIP AerChemMIP', "['RAMIP']

Declan-FMI commented 5 months ago

I disagree, activity_id is specified as "ScenarioMIP AerChemMIP" for ssp370 experiments. "RAMIP" for all others. See RAMIP_CV.json, lines 11007-11009 in (I think) the latest version.

// Declan O'Donnell (declan.odonnell -at - fmi.fi)

mollymacrae commented 5 months ago

Ahh yes, I see this thank you! I think our checks were picking this up as an error as the activity_id listed at the top (line 44) is set to "RAMIP" Maybe it would be worth updating ssp370 in the RAMIP tables to: "activity_id": ["ScenarioMIP AerChemMIP RAMIP"]

mollymacrae commented 1 month ago

Variable ccn02 standard_name attribute needs to be corrected before archival: FAILED:: Variable [ccn02] has incorrect attributes: standard_name="cloud_condensation_nuclei_concentration_at_0point2_percent_supersaturation" [correct: "cloud_condensation_nuclei_concentration_at_0.2_percent_supersaturation"]

Declan-FMI commented 1 month ago

Hi, No, it is correct as is. The standard name was changed earlier this year, May or June if I remember correctly. 0.2 is the old, 0point2 the new. Laura can probable tell you why the change was necessary. See https://github.com/ramipaerosols/RAMIP/blob/RAMIP-cmor-tables/RAMIP_RAMIPmon.json Best regards, Declan

From: mollymacrae @.> Sent: 24 October 2024 11:19 To: cedadev/RAMIP @.> Cc: O'Donnell Declan (FMI) @.>; Comment @.> Subject: Re: [cedadev/RAMIP] EC-Earth-Consortium ceda-cc report (Issue #4)

Variable ccn02 standard_name attribute needs to be corrected before archival: FAILED:: Variable [ccn02] has incorrect attributes: standard_name="cloud_condensation_nuclei_concentration_at_0point2_percent_supersaturation" [correct: "cloud_condensation_nuclei_concentration_at_0.2_percent_supersaturation"]

— Reply to this email directly, view it on GitHubhttps://github.com/cedadev/RAMIP/issues/4#issuecomment-2434607638, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP55OR454SNDGEZO4EQDX3DZ5CUSRAVCNFSM6AAAAABJR3O5TOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZUGYYDONRTHA. You are receiving this because you commented.Message ID: @.***>

mollymacrae commented 1 month ago

Thank you for confirming this.

Just to note, perhaps we could consider changing the standard_name to '0p2' for consistency with other CF standard names containing decimals e.g. volume_absorption_coefficient_of_radiative_flux_in_air_duetopm2p5_dry_aerosol_particles https://cfconventions.org/Data/cf-standard-names/current/build/cf-standard-name-table.html