cedadev / checksit

File-checking made simple
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Image reading and checking #24

Closed joshua-hampton closed 2 months ago

joshua-hampton commented 1 year ago

Started a new branch ncas-image to start work on compliance checking images, thinking in particular of the NCAS-IMAGE standard. Started on reader script that uses exiftool to read image metadata, returns all as global attributes.

Shanrahan16 commented 1 year ago

https://docs.google.com/spreadsheets/d/1VnMpprRwG8G3B4uv1MdBG-hSZ_5LklTJv0e61jUenUg/edit#gid=0

Shanrahan16 commented 1 year ago

Warnings code has been written, I just need to go through and change the yaml file so that certain fields give warnings not errors (as they do currently) e.g. warning if not a CEDA catalogue link in "Relation" (as a DOI link would be acceptable in some cases).

Shanrahan16 commented 1 year ago

I have yet to add valid url checks (as in to check if the website actually exists on the internet).

Shanrahan16 commented 1 year ago

I have yet to add valid url checks (as in to check if the website actually exists on the internet).

Complete

joshua-hampton commented 1 year ago

Does that mean that the user must be connected to the internet for this to work? For example, if someone's on campaign in the middle of nowhere, adding correct metadata on the fly and checking their files with this as they go, what message would they get?

Shanrahan16 commented 1 year ago

Warnings code has been written, I just need to go through and change the yaml file so that certain fields give warnings not errors (as they do currently) e.g. warning if not a CEDA catalogue link in "Relation" (as a DOI link would be acceptable in some cases).

Complete

Shanrahan16 commented 1 year ago

Does that mean that the user must be connected to the internet for this to work? For example, if someone's on campaign in the middle of nowhere, adding correct metadata on the fly and checking their files with this as they go, what message would they get?

We're only giving a warning for URL checks rather than an error, as URLs may not be live all the time.

Shanrahan16 commented 1 year ago

Link to spreadsheet of checks implemented: https://docs.google.com/spreadsheets/d/1VnMpprRwG8G3B4uv1MdBG-hSZ_5LklTJv0e61jUenUg/edit#gid=2140455130

Shanrahan16 commented 1 year ago

I have noticed that in amof-global-attrs.yml (NCAS General Standard), platform_altitude: regex:^\d+\.?\d*\sm$ does not allow negative values?

joshua-hampton commented 2 months ago

Closing this issue as version 1.0 of NCAS Image is in checksit