Extending existing plugins to open Level 3 data

[adamcpovey]

I've been working with various NASA and ESA Level 3 datasets. These commits are a tidied-up version of what I used to get them into CIS with the least thought at the time.

You might not want this yet. It's solves #12 but updates the dependencies.

Also, I chose to strip attributes off cubes only when opening multiple files at once. If someone tries to open individual files and then merge, they'll have to use iris.experimental.equalize_attributes().

[duncanwp]

That looks great - thanks Adam!

I should add a contribution guide, but in the meantime could you:

• [ ] Bump the version to 1.7.0 (in cis.__init__.py)
• [ ] Update the conda_requirements.py and setup.py files to reflect the updated dependencies
• [ ] Add a couple of lines to "What's New"?

[adamcpovey]

The setup script claims Iris isn't available. Trying things manually, it works on Python 2.7 if I remove the >=2.0.0. It works on Python 3.4 or 3.6 if I remove the dependency to Iris entirely from setup.py.

In all cases, Iris is definitely installed locally. setup.py just doesn't believe it is and my Google-fu has failed to uncover and explanation.

[duncanwp]

I think this is because the setup script is finding this iris rather than this one (which didn't exist before 2.0 I don't think...).

Try changing the dependency to scitools-iris and see if that helps!

[adamcpovey]

If I change this to matplotlib<1.9, it works on my machine for python 2.7 and 3.6. However, I really don't want to do that as matplotlib 1.9 is almost 2 years old.

Also, iris 2.0.0 requires python 3.6 so the python 3.4 build is doomed to failure. If you'd prefer not move up python versions, I'll work out how to take that bit out.

[duncanwp]

I'm happy to move to Python 3.6 if Iris 2.0 needs it anyway. You should just need to update the .travis.yml file.

[duncanwp]

@adamcpovey sorry for the pain in getting this merged. This is because the iris conda requirements don't specify the matplotlib requirements, but their pip ones do. Can you try just removing the scipy-iris dependency from the setup.py file. That should stop it checking the matplotlib versions.

[adamcpovey]

That's more errors than I reasonably know what to do about.

[duncanwp]

No worries – I’ll take a look. Thanks for getting it this far 😊

From: Adam Povey notifications@github.com Sent: 04 May 2018 15:33 To: cedadev/cis cis@noreply.github.com Cc: Duncan Watson-Parris duncan.watson-parris@physics.ox.ac.uk; Comment comment@noreply.github.com Subject: Re: [cedadev/cis] Extending existing plugins to open Level 3 data (#13)

That's more errors than I reasonably know what to do about.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/cedadev/cis/pull/13#issuecomment-386620334, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADBdVL1x17KdeQ6ePTH_zkRZXlGnkpAuks5tvGaIgaJpZM4THGlf.

[duncanwp]

I resolved the conflicts my end - thanks for the work @adamcpovey !