Closed adamcpovey closed 2 years ago
I got a bit excited and merged it already, but I’ll remove it now!
From: Adam Povey @.> Sent: 24 January 2022 10:25 To: cedadev/cis @.> Cc: Duncan Watson-Parris @.>; State change @.> Subject: Re: [cedadev/cis] Assorted bug fixes and tidying you might want (PR #34)
@adamcpovey commented on this pull request.
In cis/data_io/hyperpoint.pyhttps://github.com/cedadev/cis/pull/34#discussion_r790599787:
@@ -22,11 +22,15 @@ def new(cls, lat=None, lon=None, alt=None, pres=None, t=None, val=None):
Small constructor for the HyperPoint named tuple to allow optional arguments
and set-up value list.
"""
You appear to be correct
— Reply to this email directly, view it on GitHubhttps://github.com/cedadev/cis/pull/34#discussion_r790599787, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAYF2VBVQAQ4HG6BZZSSPYLUXUSJRANCNFSM5G4WBSIQ. You are receiving this because you modified the open/close state.Message ID: @.**@.>>
I should probably share the changes I've made to CIS so you can decide if you want them. Tell me which ones you want and I can make a separate branch for a tidy merge. I expect the following to be discretionary:
LogFormatterMathtextSpecial
if you have any desire to resurrect it.conda update -y --all
on the wrong environment and being too stubborn to revert. There will be dependency implications that I haven't committed and don't know if you want to carry.