search

cedadev / nappy

NASA Ames Processing in PYthon (NAPPy) - a Python library for reading, writing and converting NASA Ames files.
BSD 3-Clause "New" or "Revised" License
9 stars 13 forks source link

Typing module (python>=3.5) helps understanding nappy in IDE coding assistance #37

Closed poelsner closed 7 months ago

poelsner commented 3 years ago

The usage of nappy can be improved by the usage of types and the typing module. But the typing module was introduced with Python 3.5, so the required python version (in setup.py) should be updated. Maybe this can also make conflicts - a strategy decision about nappy.

agstephens commented 3 years ago

@poelsner Thanks for this suggestion. We are aware of the typing module and we use it on some repositories. However, I am not sure if we will adopt it for nappy. I will discuss with colleagues.

agstephens commented 3 years ago

Hi @poelsner, Our consensus is not to implement the Typing module definitions for nappy at this point in time. If you have a strong case to do it, then please implement it in your own fork and put a full PR in. If it has been done for the entire codebase then I think we would accept the PR. :-)