cedadev / nappy

NASA Ames Processing in PYthon (NAPPy) - a Python library for reading, writing and converting NASA Ames files.
BSD 3-Clause "New" or "Revised" License
9 stars 13 forks source link

Fix bug hiding aux variables (issue #43) #44

Closed LukeJones123 closed 2 years ago

LukeJones123 commented 2 years ago

Pull Request Checklist:

agstephens commented 2 years ago

Hi @LukeJones123, this PR looks good. Thanks for spotting this bug. Could you please add a unit test, or modify an existing one, to verify that the aux variables are being correctly accessed. Then I will merge the PR.

LukeJones123 commented 2 years ago

Hi Ag. I added a test to test_na_file.py. Running that revealed another bug actually, in getAuxVariable(), which I've also now fixed as part of this branch.

agstephens commented 2 years ago

@LukeJones123 Thanks for finding the bugs and adding fixes. I'm re-running the CI now.

agstephens commented 2 years ago

Hi @LukeJones123, tests are now passing which is great. Please can you update the HISTORY.rst file to note this change, and feel free to add yourself as an author to the AUTHORS.md (unless you'd rather remain anonymous - which is also fine :-)

LukeJones123 commented 2 years ago

Hi Ag. The HISTORY.rst is formatted using version numbers and release dates. What values would you like me to use there?

LukeJones123 commented 2 years ago

And do you want me to add a comment for the units-parsing feature branch too?

agstephens commented 2 years ago

Hi @LukeJones123, yes please.

agstephens commented 2 years ago

@LukeJones123, in the HISTORY.rst file, please add a section with the title: v2.0.2 (pending release) - and I'll create a new release when the current set of updates/fixes are merged. Thanks

LukeJones123 commented 2 years ago

Hi Ag. I've done that now.

agstephens commented 2 years ago

Thanks @LukeJones123