search

cedadev / nappy

NASA Ames Processing in PYthon (NAPPy) - a Python library for reading, writing and converting NASA Ames files.
BSD 3-Clause "New" or "Revised" License
9 stars 13 forks source link

Remove CI support for Python 3.6 #51

Closed agstephens closed 2 years ago

agstephens commented 2 years ago

Hi @FObersteiner and @LukeJones123, you have both been active in helping improve Nappy recently. When reviewing the first Pull Request I see that it fails with Python 3.6 in the GitHub Actions CI. I don't think we need to support Python3.6 anymore. Are you happy to remove support for Python3.6?

FObersteiner commented 2 years ago

Hi Ag, yes I'm totally fine with dropping support for Python 3.6!

LukeJones123 commented 2 years ago

Hi, yes, me too.

agstephens commented 2 years ago

@LukeJones123 @FObersteiner: thanks. Please can you remove 3.6 in the .github/workflows/main.yml file in the branches you have used for your Pull Requests, and then the CI should run to completion and I can start merging them. Thanks

LukeJones123 commented 2 years ago

Done.

FObersteiner commented 2 years ago

I think this can be closed.