search

cedadev / nlds

Near Line Data Store
Other
9 stars 0 forks source link

Fix for modify holding attribute error #61

Closed jackleland closed 1 year ago

jackleland commented 1 year ago

This is to fix the failing test on modify_holding(), which is due to the lack of input checking done on the holding passed into the function. This could just as easily be fixed by wrapping everything in a try-catch to catch an AttributeError later in the function, but I think this pre-empts that and makes it a bit neater. Lemme know your thoughts.

nmassey001 commented 1 year ago

Looks good. Maybe we should add the same check to the other functions that take Holding as a parameter.