cedadev / snap

SNAP Coordinated Stratospheric Nudging Experiments
BSD 2-Clause "Simplified" License
0 stars 6 forks source link

Issue15 matthew mizielinski CVs and tables fixes #16

Closed matthew-mizielinski closed 1 year ago

matthew-mizielinski commented 1 year ago

Changes I've made to get this past CMOR:

Other changes:

A number of the above should be reviewed and possibly altered depending on your purposes. In particular the use of allowed_model_components / required_model_components in the experiment definitions, the plev137 pressure level entry and the license pattern should be considered further.

P.S. The edits to the CVs were made a little crudely. Might be worth pushing through the JSON library to get a cleaner structure (python -m json.tool <input file> would clean this up).

matthew-mizielinski commented 1 year ago

Note that @charliepascoe has a different take on the table_id field (see #12) -- I've had to restore the Table prefix in this pull request to ensure that our code around (but not in) CMOR works as this is the structure we are used to with the CMIP6 tables.

charliepascoe commented 1 year ago

Thanks Matthew, I now need to remember to pull this update into the MIP tables that ceda-cc references.

matthew-mizielinski commented 1 year ago

@charliepascoe, you might be able to shortcut that process using the git submodule command -- I've seen this done in other repositories and then you may not have to manually copy files across.