cedadev / snap

SNAP Coordinated Stratospheric Nudging Experiments
BSD 2-Clause "Simplified" License
0 stars 6 forks source link

hlin011 ceda-cc report for GEM-NEMO v20221004 #24

Open mollymacrae opened 1 year ago

mollymacrae commented 1 year ago

The data passed checks except comments below:

mollymacrae commented 1 year ago

variables (hus, pr, prc etc.) missing cell_methods attribute in all files, for example error:

C4.002.005: [variable_ncattribute_mipvalues]: FAILED:: Variable [hus] has incorrect attributes: cell_methods="Attribute not present" [correct: "area: mean time: point"]

Need to specify cell_methods from the corresponding snapsi table

mollymacrae commented 1 year ago

time coordinate units need to be 'days since 1970-01-01' rather than 'seconds since 1970-01-01'.

Error: C4.003.001: [time_attributes]: FAILED:: time units [seconds since 1970-01-01 00:00:00.0 0:00] attribute not set correctly to "days since ....." C4.003.001: [time_attributes]: FAILED:: Time: required attribute calendar missing

mollymacrae commented 1 year ago

Please change the global attributes 'realization_index', 'initialization_index' and 'physics_index' from strings to tuples on all files. For example, currently: realization_index = "1LL" when it should be: realization_index = 1LL

Error: C4.002.006: [global_ncattribute_cv]: FAILED:: Global attributes do not match constraints: [('realization_index', '1LL', "Value is not instance of required class (<class 'tuple'>): 1LL -- <class 'str'>"), ('initialization_index', '06', "Value is not instance of required class (<class 'tuple'>): 06 -- <class 'str'>"), ('physics_index', '1LL', "Value is not instance of required class (<class 'tuple'>): 1LL -- <class 'str'>"), ('forcing_index', '1LL', "Value is not instance of required class (<class 'tuple'>): 1LL -- <class 'str'>")]

mollymacrae commented 1 year ago

Add attribute missing_value for variables with _FillValue attribute: missing_value = 1e+20

For data with _FillValue attribute, the _FillValue should be 1e+20 and is currently 9.96921e+36(variables tntnd and utntnd) or 9.999e+20. Please change so that _FillValue = 1e+20 This error applies to:

all files with variables tntnd and utntnd in '/control/' and '/nudged/' directories and

filenames with XX replaced with ensemble number in '/nudged/' directory:

ps_6hrPt_GEM-NEMO_nudged_s20191001_r1iXXp1f1_gr_20191001-20191115.nc psl_6hrPt_GEM-NEMO_nudged_s20191001_r1iXXp1f1_gr_20191001-20191115.nc rlut_6hrPt_GEM-NEMO_nudged_s20191001_r1iXXp1f1_gr_20191001-20191115.nc tas_6hrPt_GEM-NEMO_nudged_s20191001_r1i10p1f1_gr_20191001-20191115.nc

Error: C4.002.005: [variable_ncattribute_mipvalues]: FAILED:: missing_value must be present if _FillValue is [tntnd] C4.002.005: [variable_ncattribute_mipvalues]: FAILED:: Variable [tntnd] has incorrect attribute _FillValue=9.96921e+36 [correct: 1e+20]

mollymacrae commented 1 year ago

New errors from second CEDA-cc check:

mollymacrae commented 1 year ago

The mip_era global attribute needs to be set to 'CMIP6' and is currently 'SNAPSI' for all files. Error: C4.002.006: [global_ncattribute_cv]: FAILED:: Global attributes do not match constraints: [('mip_era', 'SNAPSI', "['CMIP6']")]

mollymacrae commented 1 year ago

Files for variables 'siconca' and 'tos' have a missing attribute error. The the attribute missing_value must be added when the _FillValue attribute is present. Please could you add variable attribute e.g. tos:missing_value = 1.e+20f. Error: C4.002.005: [variable_ncattribute_mipvalues]: FAILED:: missing_value must be present if _FillValue is [tos]

mollymacrae commented 1 year ago

Files for variable 'va' have the incorrect cell_methods attribute. The cell_methods attribute needs to be changed from "time: point" to "longitude: mean time: point". ​Error: ​C4.002.005: [variable_ncattribute_mipvalues]: FAILED:: Variable [va] has incorrect attributes: cell_methods="time: point" [correct: "longitude: mean time: point"]

aph42 commented 1 year ago

Just to confirm what Hai mentioned in his email regarding the mip_era attribute - we did make the late decision to switch the mip_era to 'SNAPSI'.