Make use of image format

cedadev / swallow

Swallow - a Birdhouse WPS for running the NAME Trajectory code.

Other

0 stars 1 forks source link

Make use of image format #49

Closed alaniwi closed 1 year ago

alaniwi commented 2 years ago

Plot type input is currently being ignored (PNG always written). Pass this through and check that matplotlib will generate plots of the correct type. If option not available in ADAQ for any reason, then include a postprocessing step if not PNG.

alaniwi commented 2 years ago

The above was my commit.

It fixes it for trajectory plots, but the underlying routines in ADAQ don't seem to support a filename input argument for the plot field routine that is used by the general forward and air history runs. For now, I have removed the image format input from those run types. We could post-process any PNG files found in the output directory, using "convert". This would require imagemagick to be installed in the conda environment.

alaniwi commented 1 year ago

This is now working. The PDF plots are not particularly well centered in the cases where:

trajectory run - there the relevant adaqpython routine permits a filename argument so this is passed, and the pdf rendering is done by matplotlib
air history run where the PNG file contains a large white area on the right; the routine I added then centres the PNG file itself on the page but because this file contains a white area, the plot itself is not

Both of these are issues that could be addressed inside ADAQ, not the responsibility of the WPS.