search

cedar-policy / cedar-docs

Documentation for Cedar policy language
https://docs.cedarpolicy.com
Apache License 2.0
22 stars 19 forks source link

Add documentation for new `is` operator #67

Closed john-h-kastner-aws closed 9 months ago

john-h-kastner-aws commented 9 months ago

Adding docs for is operator which will be released in the upcoming Cedar 3.0 release.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

cdisselkoen commented 9 months ago

to reflect that the is operator corresponds to a new language version (2.2.0?).

Cedar SDK 3.0 will also have to be language 3.0; although is is not a breaking change for the language, things like RFC 20 are.

AMZ-brandon commented 9 months ago

I'm putting together a preview in my test repo. This branch is behind main - can you update it from the base branch?

john-h-kastner-aws commented 9 months ago

updated

AMZ-brandon commented 9 months ago

Thanks for updating! I've pulled the branch - preview here.

I am updating the document history and adding syntax highlighting to is.

What should be the new language version for the doc history? 3.0? And what PR in the Cedar repo matches this update?

john-h-kastner-aws commented 9 months ago

What should be the new language version for the doc history? 3.0?

Yes. This will be released with version 3.0 (to be release soon).

And what PR in the Cedar repo matches this update?

is was added in https://github.com/cedar-policy/cedar/pull/396 following to the design in rfc5

AMZ-brandon commented 9 months ago

Let me know if that doc history update looks accurate. Otherwise LGTM & will merge.

john-h-kastner-aws commented 9 months ago

We should wait on the merge until the 3.0 release happens so we don't have is referenced in the docs before the new version is on crates.io. That will be a week or two probably.

AMZ-brandon commented 9 months ago

Got it, standing by until I hear of the release.