search

cedar-policy / cedar-java

Java bindings for the Cedar language
https://www.cedarpolicy.com
Apache License 2.0
42 stars 19 forks source link

update for cedar#794 #127

Closed cdisselkoen closed 6 months ago

cdisselkoen commented 6 months ago

Issue #, if available:

cedar-policy/cedar#794

Description of changes:

Also a couple unrelated nits.

CedarJavaFFI tests are currently failing due to #126.

cdisselkoen commented 6 months ago

I'm not sure what is causing the current CI failure.

john-h-kastner-aws commented 6 months ago

I'm not sure what is causing the current CI failure.

It looks like Build on Linux is trying to run /home/runner/.cache/cargo-zigbuild/0.18.3/zigcc-aarch64-apple-darwin.sh. Could be a problem.

cdisselkoen commented 6 months ago

That's super weird because you wouldn't think any of the changes in this PR could be affecting the zig build (I think?)

john-h-kastner-aws commented 6 months ago

Zig did release a new version 4 days ago: https://ziglang.org/download/0.12.0/release-notes.html

john-h-kastner-aws commented 6 months ago

Confirmed build works on Linux with zig 0.11.0 from https://ziglang.org/download/

cdisselkoen commented 6 months ago

cargo-zigbuild made a new release today which seems to have added zig 0.12.0 (at least, it adds tests against zig 0.12.0 to their CI). I will see if that works

cdisselkoen commented 6 months ago

Alright, build has passed now, after I both downgraded to zig 0.11.0 and also locked the version of cargo-zigbuild to the current latest for good measure.