Adding support for entity tags - Githubissues

cedar-policy / cedar-java

Java bindings for the Cedar language

https://www.cedarpolicy.com

Apache License 2.0

42 stars 19 forks source link

Adding support for entity tags #238

Closed mark-creamer-amazon closed 1 week ago

mark-creamer-amazon commented 1 week ago

Use Case

Entity tagging is new in Cedar 4.2.x, but CedarJava 4.2.x is not able to leverage it with the current Entity object and serializer.

Details

Adding tags field to Entity.java to support entities with tags
Updated EntitySerializer.java to make sure the tags field makes it across the JNI layer and into the AuthorizationRequest string we pass.
Quality of life improvement: returning the error message in the case of Validation errors in the corpus/json tests in executeJsonValidationTest

Testing

Added testEntityWithUnknownTag to EntityValidationTests.java
Created a temporary extra json test among JSON_TEST_FILES that tested e2e allowing an action contingent on a tag being present in the resource.

cdisselkoen commented 1 week ago

Can we make sure to make the same change on main as well?

mark-creamer-amazon commented 1 week ago

Can we make sure to make the same change on main as well?

Created here: https://github.com/cedar-policy/cedar-java/pull/239