cedar-policy / cedar

Implementation of the Cedar Policy Language
https://www.cedarpolicy.com
Apache License 2.0
892 stars 80 forks source link

Add Entity Slicing using Entity Manifests to Cedar #1105

Closed oflatt closed 1 month ago

oflatt commented 3 months ago

Description of changes

This PR allows users of Cedar to get an entity slice of an existing Entities store using the entity manifest. Mainly this is useful for testing entity manifests. However, it may also be useful for users to load all entities in to memory, but only send a slice over the network to a server.

Later, I re-implemented most of this code in #1208. You can squash this code with all the PRs on top of it into one giant PR, or just review this and then review the replacement.

PR stack: https://github.com/cedar-policy/cedar/pull/1102 (Merged) https://github.com/cedar-policy/cedar/pull/1105 (This PR) https://github.com/cedar-policy/cedar/pull/1154 https://github.com/cedar-policy/cedar/pull/1156 https://github.com/cedar-policy/cedar/pull/1171

1196

https://github.com/cedar-policy/cedar/pull/1208

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

I confirm that this PR (choose one, and delete the other options):

I confirm that cedar-spec (choose one, and delete the other options):

oflatt commented 3 months ago

This PR stacks on top of #1102 It looks like I can't select that PR as a base branch since it's from my fork of Cedar.

oflatt commented 3 months ago

Looks like changing the API for cedar testing broke downstream dependencies build

shaobo-he-aws commented 1 month ago

Closed in favor of a single PR.