This PR adds a new way to load entities based on their ids. This makes entity slicing easier to implement, since the trait implementor does not need to worry about entity dereferences. To make this PR work, type annotations had to be added to the entity manifest.
The API is flexible: users can choose to use the [AccessTrie] in entity requests to only load some fields of entities. It's also batched, so that as many entities as possible are loaded at the same time (in a breadth-first traversal of the entity manifest).
Loading of ancestors is separated from loading of entities so that particular ancestors can be named.
This PR doesn't make this API public yet, but it could be made public with some wrapper structs.
The change in this PR is (choose one, and delete the other options):
[ ] A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
[ ] A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
[ ] A bug fix or other functionality change requiring a patch to cedar-policy.
[x] A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
[ ] A change (breaking or otherwise) that only impacts unreleased or experimental code.
I confirm that this PR (choose one, and delete the other options):
[ ] Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
[x] Does not update the CHANGELOG because my change does not significantly impact released code.
I confirm that cedar-spec (choose one, and delete the other options):
[ ] Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
[ ] Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
[x] Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
[ ] I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)
Description of changes
This PR adds a new way to load entities based on their ids. This makes entity slicing easier to implement, since the trait implementor does not need to worry about entity dereferences. To make this PR work, type annotations had to be added to the entity manifest.
The API is flexible: users can choose to use the [
AccessTrie
] in entity requests to only load some fields of entities. It's also batched, so that as many entities as possible are loaded at the same time (in a breadth-first traversal of the entity manifest).Loading of ancestors is separated from loading of entities so that particular ancestors can be named.
This PR doesn't make this API public yet, but it could be made public with some wrapper structs.
PR stack: https://github.com/cedar-policy/cedar/pull/1102 https://github.com/cedar-policy/cedar/pull/1105 https://github.com/cedar-policy/cedar/pull/1154 https://github.com/cedar-policy/cedar/pull/1156 https://github.com/cedar-policy/cedar/pull/1171
1196
https://github.com/cedar-policy/cedar/pull/1208 (This PR)
DRT testing PR: https://github.com/cedar-policy/cedar-spec/pull/429
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., changes to the signature of an existing API).cedar-policy
(e.g., addition of a new API).cedar-policy
.cedar-policy-core
,cedar-validator
, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):cedar-spec
, and how you have tested that your updates are correct.)cedar-spec
. (Post your PR anyways, and we'll discuss in the comments.)