Hides the existing RFC 82 implementation code (#1204) behind an experimental feature flag, entity-tags.
This PR chooses to leave the parser grammar and JSON structures the same, and only report an error at the point we construct a ValidatorSchema. This enables us to have a much nicer error message if someone tries to use tags without enabling the feature. It does mean that a lot of the "experimental" parser code is not deactivated when the feature is deactivated, but I think this is acceptable.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
[x] A change (breaking or otherwise) that only impacts unreleased or experimental code.
I confirm that this PR (choose one, and delete the other options):
[x] Does not update the CHANGELOG because my change does not significantly impact released code.
I confirm that cedar-spec (choose one, and delete the other options):
[x] Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
Description of changes
Hides the existing RFC 82 implementation code (#1204) behind an experimental feature flag,
entity-tags
.This PR chooses to leave the parser grammar and JSON structures the same, and only report an error at the point we construct a
ValidatorSchema
. This enables us to have a much nicer error message if someone tries to use tags without enabling the feature. It does mean that a lot of the "experimental" parser code is not deactivated when the feature is deactivated, but I think this is acceptable.Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):cedar-spec
, and how you have tested that your updates are correct.)