Entity slicing with manifest

shaobo-he-aws commented 1 month ago

Description of changes

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

[x] A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

[x] Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

[x] Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

[x] Does not require updates because my change does not impact the Cedar language specification.

oflatt commented 1 month ago

What's the plan on making it compatible with entity tags? I suggest making the two features incompatible for now

shaobo-he-aws commented 2 weeks ago

What's the plan on making it compatible with entity tags? I suggest making the two features incompatible for now

Entity tags has been a released feature. So, we will temporary make entity manifest error on policies using entity tags.

john-h-kastner-aws commented 1 week ago

also, can you confirm that you've looked into the details of the SemVer Checks failure? it's presumably behind a feature flag, but we should be sure of that

shaobo-he-aws commented 1 week ago

also, can you confirm that you've looked into the details of the SemVer Checks failure? it's presumably behind a feature flag, but we should be sure of that

Yes. I looked into it. This PR removed an enum variant which is under the feature flag. So it should be a false alarm.

cedar-policy / cedar