This PR extends the validation of action IDs so that we detect cases in which the user may have mistakenly included the entity type (i.e., "Action::") in the action ID. In that case, we don't suggest another action ID like we used to, but instead draw attention to the fact that the action ID was defined with the entity type in its name. This avoids misleading the user when the fix is much simpler.
Resolves #166
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
[x] A bug fix or other functionality change requiring a patch to cedar-policy.
I confirm that this PR (choose one, and delete the other options):
[x] Does not update the CHANGELOG because my change does not significantly impact released code.
I confirm that cedar-spec (choose one, and delete the other options):
[x] Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
Description of changes
This PR extends the validation of action IDs so that we detect cases in which the user may have mistakenly included the entity type (i.e.,
"Action::") in the action ID. In that case, we don't suggest another action ID like we used to, but instead draw attention to the fact that the action ID was defined with the entity type in its name. This avoids misleading the user when the fix is much simpler.Resolves #166
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy.I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):