search

cedar-policy / rfcs

Apache License 2.0
10 stars 8 forks source link

RFC 0040 - add trait implementations to export structs to JSON Schema #40

Closed Swolebrain closed 10 months ago

Swolebrain commented 11 months ago

Rendered

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

khieta commented 11 months ago

Hi @Swolebrain I discussed this with the team today, and we're all on board with deriving JsonSchema for more Cedar types (although we want to be careful about not accidentally exposing internal datatypes -- but we can iron this out when reviewing the PR). We also think it's a good idea to put this behind a flag so that users aren't required to take the dependency/extra compile time if they don't need it.

We also agreed that the RFC mechanism is a little heavy weight for this particular request, since it's not changing the language per se. We'd prefer using an issue to track this instead -- I've taken the liberty of porting to an issue here: https://github.com/cedar-policy/cedar/issues/492

Let me know if that sounds ok and I'll close the RFC. Thanks for submitting this!