search

cedar-policy / rfcs

Apache License 2.0
10 stars 8 forks source link

Disallow shadowing definitions in the empty namespace #70

Closed cdisselkoen closed 3 months ago

cdisselkoen commented 4 months ago

Rendered

aaronjeline commented 4 months ago

We could even codify that rule, requiring that all libraries have a name and all declarations in the library live in the corresponding namespace, or alternately, implicitly prefixing all library declarations with the library name as a toplevel namespace. Many existing package systems have similar rules or mechanisms.

This is addressing my primary worry.

shaobo-he-aws commented 4 months ago

LGTM.

cdisselkoen commented 4 months ago

The final comment period (FCP) for this RFC is starting now, with intent to accept. The FCP will end 2024-07-17 at 10am PT / 1pm ET / 5pm UTC. Please add comments, and especially any objections, if you have any. For more on the RFC process, see https://github.com/cedar-policy/rfcs.

cdisselkoen commented 3 months ago

Merging this, having addressed the concern that was raised during FCP.