search

cedarbdd / cedar

BDD-style testing using Objective-C
http://groups.google.com/group/cedar-discuss
1.19k stars 140 forks source link

Pending tests should be printed when running under XCTest #371

Closed briancroom closed 8 years ago

briancroom commented 8 years ago

This modifies the way that Cedar integrates with the XCTest runner such that pending tests aren't ignored entirely, but are still made known to the example reporters. This results in the pending test count and summary info being included in Cedar's test output. The pending tests aren't exposed to XCTest, however, since there is no way to represent the "pending" state in its framework.

This addresses #303 and https://www.pivotaltracker.com/story/show/99707426.

(Inspired by a recent conversation with @pivotal/team-cedar, I also swapped the ad-hoc Cedar fake in CDRXCTestSuiteSpec with a full-fledged test double class.)

briancroom commented 8 years ago

@pivotal-misa-sakamoto I encountered this issue most recently with you, it would be great if you could give it a try and see if it resolves the issue of pending tests not being reflected in the summary output.

Same goes for @idoru and @tjarratt if you've got test bundle projects going right now :)

idoru commented 8 years ago

Sorry this sat here so long; I finally had some spare time to test it out today.

I didn't see any reason not to merge this, since our lack of reporting pending tests has been broken for a long time (#303).

idoru commented 8 years ago

LOL totally hamfisted that. Merged anyway since the checks had passed previously before I accidentally closed the PR. Thanks for the fixing this, @briancroom

briancroom commented 8 years ago

:+1: Thanks for taking a look and doing the honors @idoru!