search

cedarbdd / cedar

BDD-style testing using Objective-C
http://groups.google.com/group/cedar-discuss
1.19k stars 140 forks source link

Expose failing test in CI and then fix the failing test #374

Closed wileykestner closed 8 years ago

wileykestner commented 8 years ago

As discussed with @tjarratt, we discovered that building the "Cedar-iOS Specs" target in Release configuration would create a Cedar suite application that, when run, had a failing test.

The feature with the failing test is the feature to report line numbers of method calls in stack traces when an exception is raised during a test run (search the tests for callStackSymbolicatedSymbols).

We are assuming that the reason that the "Cedar-iOS Specs" target has a failure in Release mode is that the compiler optimization build setting (-0s) was causing the line counts to be incorrect in some cases. So this PR also includes a change to set the optimization level to None -O0 in Release mode.

Your insights and comments on the matter are solicited.

tjarratt commented 8 years ago

Thank you for the contributions @reneighbor and @wileykestner!

reneighbor commented 8 years ago

:)

On Mon, Feb 1, 2016 at 12:25 PM, Tim Jarratt notifications@github.com wrote:

Merged #374 https://github.com/pivotal/cedar/pull/374.

— Reply to this email directly or view it on GitHub https://github.com/pivotal/cedar/pull/374#event-534772364.

Renee Chu