search

cedarcode / webauthn-rails-demo-app

Rails app demonstrating a WebAuthn password-less login
https://webauthn.cedarcode.com
Apache License 2.0
97 stars 38 forks source link

Feature Request: Package as a Rails engine #116

Open mhoad opened 4 years ago

mhoad commented 4 years ago

This demo is extremely helpful and I am incredible grateful for it. I was wondering if you would be willing to perhaps look at doing this as a Rails engine that can just be dropped into any kind of Rails project much in the same way that Devise works.

It seems like there is still quite a bit of work between say adding gem "webauthn" to the Gemfile and a functional Rails implementation. Given that the work already exists as a part of this repo I wanted to see if this made sense for your plans as I think it would be hugely helpful to the community in general.

grzuy commented 4 years ago

Hi @mhoad ,

Happy to read you find this demo helpful.

We've had some discussion recently around how to provide some of this out of the box. Coding a devise extension has been one of the options considered so far.

grzuy commented 4 years ago

Haven't thought about a rails engine until now, so we should also consider that as a possibility...

Thanks for sharing your ideas.

mhoad commented 4 years ago

Glad to hear from you. I think what you’ve done is a huge contribution to the overall rails community. I’d love to see it have the opportunity to be more widely shared. Merry Christmas in the meantime

On Tue, 24 Dec 2019 at 14:41, Gonzalo Rodriguez notifications@github.com wrote:

Haven't thought about a rails engine until now, so we should also consider that as a possibility...

Thanks for sharing your ideas.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cedarcode/webauthn-rails-demo-app/issues/116?email_source=notifications&email_token=AABAPDPTONMTEEE5SITY3I3Q2INRJA5CNFSM4J5KIUMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHTJNMY#issuecomment-568759987, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABAPDIFQZ75ET6UH45JVCTQ2INRJANCNFSM4J5KIUMA .

joshbuker commented 3 years ago

I have plans on introducing WebAuthn support (in particular, U2F) to Sorcery v1, for anyone interested. Sorcery acts as a lightweight interface that will probably be similar to what @mhoad is looking for.

@grzuy maybe we could chat sometime about implementation?

grzuy commented 3 years ago

I have plans on introducing WebAuthn support (in particular, U2F) to Sorcery v1, for anyone interested. Sorcery acts as a lightweight interface that will probably be similar to what @mhoad is looking for.

That's great to hear!

@grzuy maybe we could chat sometime about implementation?

Feel free to join https://gitter.im/cedarcode/webauthn-ruby :-)