search

cedarcode / webauthn-rails-demo-app

Rails app demonstrating a WebAuthn password-less login
https://webauthn.cedarcode.com
Apache License 2.0
99 stars 39 forks source link

Split registration and authentication user flows #53

Closed grzuy closed 5 years ago

grzuy commented 5 years ago

In hindsight it's quite logical 🤦‍♂️ SessionController does dual duty as both registration and authentication controller, depending on the availability of credentials. I'll open a PR to refactor this a bit since I find it not very intuitive or a good example for somebody's production app.

Originally posted by @bdewater in https://github.com/cedarcode/webauthn-rails-demo-app/pull/33#issuecomment-427591687

grzuy commented 5 years ago

I agree with @bdewater that having Registration with Authentication mixed in the same user flow is confusing from a end-user perspective.

grzuy commented 5 years ago

@bdewater Are you already in progress with this? If not I can work on it. I do want to fix this UX confusion sooner than later :-)

Thanks!

sandergroen commented 5 years ago

@grzuy I already did some refactoring locally. I have separated the registration and authentication flows. I can make a pull request if you like.

grzuy commented 5 years ago

@sandergroen Yes, please, pull request would be great, thank you! :-)

bdewater commented 5 years ago

Sorry I missed the ping, did not have the time to tackle it myself but happy to see somebody else taking a stab at it :)

grzuy commented 5 years ago

@bdewater No worries. Thank you for raising the concern initially!

grzuy commented 5 years ago

Closed by #56