What do you think about using attestation_trust_path on AttestationStatement::FidoU2f#valid? instead of [attestation_certificate]? Just for the sake of consistency among formats.
Good call. Will do :+1:
Also, on AttestationStatement::AndroidSafetynet, once we return the whole certificate chain (instead of only the leaf certificate) we could redefine attestation_trust_path to return the certificate chain and ditch attestation_certificate
Right. I am adding a comment to mention this inconsistency but we can fix it on a separate PR, given it doesn't fit into a "refactor" PR like this one.
grzuy
commented
4 years ago
Good call. Will do :+1:
Right. I am adding a comment to mention this inconsistency but we can fix it on a separate PR, given it doesn't fit into a "refactor" PR like this one.