search

cedarcode / webauthn-ruby

WebAuthn ruby server library ― Make your Ruby/Rails web server become a conformant WebAuthn Relying Party
https://rubygems.org/gems/webauthn
MIT License
649 stars 53 forks source link

Updated OpenSSL requirement to avoid build issues on newer systems #361

Closed itay-grudev closed 2 years ago

itay-grudev commented 2 years ago

Updated the OpenSSL version requirement to avoid build issues on newer systems. For example Ubuntu 22.04 comes with OpenSSL v3 by default. This gem doesn't use any v2 specific functionality and the upgrade doesn't cause any side effects.

I added the <3.1 as an upper bound and potential breaking API changes. This could be revised in the future when it is released.

All the tests passed with:

  Fetching openssl 3.0.0
  Installing openssl 3.0.0 with native extensions

P.S. I would really appreciate it if you release this as v3.0.0.alpha2 so I don't have to run a fork of our own and it's blocking our new feature release. P.P.S. Ping me if you need any additional changes.

itay-grudev commented 2 years ago

Closing in favour of #360 as it covers breaking changes when the binding is compiled against OpenSSL v3.

itay-grudev commented 2 years ago

Please look into merging it into your new v3 release.

brauliomartinezlm commented 2 years ago

@itay-grudev I need to backport the changes from 2_stable into 3_dev to cut a release for alpha2. I will be doing that shortly but there's some conflicts and after I solved them I got some failing tests I need to look into. Feel free to open a PR against 3_dev or else I'll try to get to it in a couple of days.

Thank you and sorry for the delay in tackling all the openssl 3 issues/PRs