search

cedarcode / webauthn-ruby

WebAuthn ruby server library ― Make your Ruby/Rails web server become a conformant WebAuthn Relying Party
https://rubygems.org/gems/webauthn
MIT License
644 stars 51 forks source link

Rename reserved bits 2 and 3 into `backup_eligibility` and `backup_state` #383

Closed lgarron closed 1 year ago

lgarron commented 1 year ago

These bits are now assigned in the WebAuthn spec: https://w3c.github.io/webauthn/#authenticator-data The spec also contains additional information about the semantics of these bits, including one currently forbidden combination.

For now, this change only implements the bits without offering or using any interpretation of them, or of their combined values.

hagould commented 1 year ago

For now, this change only implements the bits without offering or using any interpretation of them, or of their combined values.

Either now or as a follow-up, can we add support for these flags to the fake_authenticator?

santiagorodriguez96 commented 1 year ago

Hey @lgarron! Thanks for your contribution as always!

This is duplicated with #378 right? Agree this is a nice feature from the new standard that we should include 🙂

lgarron commented 1 year ago

This is duplicated with #378 right? Agree this is a nice feature from the new standard that we should include 🙂

Ah, yeah, apologies, I missed that PR!

I'd be glad to see either merged — @hagould would like to use this for GitHub as soon as we can!

santiagorodriguez96 commented 1 year ago

This is duplicated with #378 right? Agree this is a nice feature from the new standard that we should include 🙂

Ah, yeah, apologies, I missed that PR!

I'd be glad to see either merged — @hagould would like to use this for GitHub as soon as we can!

Cool! If you don't mind, I'll merge #378 which also adds a couple of specs – which can be useful for documentation – as well the possibility of setting the flags on the authenticator_data – minor details, but maybe useful 😄

I'll try to push a new version of the gem tomorrow – I'll guess they can use the master branch for the moment? Let me know 🙂

santiagorodriguez96 commented 1 year ago

Closing this on favor of #378, as discussed