Closed olleolleolle closed 10 months ago
Hey @olleolleolle! Thank you so much for your contribution!
However, we were thinking about just inlining the implementation of base64
since it's just a thin wrapper and we don't even need all its methods.
Feel free making this adjustment in this PR (or create a new one). Otherwise I will try creating a new PR for the inlining change in the coming week 🙂
@santiagorodriguez96 Hope your weekend's good!
I think there's something missing here. The require in the file is still present, and U2fMigrator
still calls base64 methods.
@Earlopain https://github.com/cedarcode/webauthn-ruby/blob/657a2789cfa8c437369b32b52f5320cf5fb77403/lib/webauthn/u2f_migrator.rb#L46 Indeed! In order to capture that where it can be seen, Issue #422.
This avoids a warning emitted by Ruby 3.3.0-preview2.
Fixes #401.
EDIT: inline the base64 implementation, and leave code comments that remind the reader about what they are seeing there.
Turn the base64 gem into a spec-supporting development dependency.