Use local base64_ functions

cedarcode / webauthn-ruby

WebAuthn ruby server library ― Make your Ruby/Rails web server become a conformant WebAuthn Relying Party

https://rubygems.org/gems/webauthn

MIT License

644 stars 51 forks source link

Use local base64_ functions #423

Open olleolleolle opened 6 months ago

olleolleolle commented 6 months ago

This PR completes the move away from the base64 gem.

First, I removed the development dependency on base64.
Then I typed all the changes to the test files.
Then, I added one more local implementation of the base64_ functions.

Then, two tests failed. I ran out of steam. Can you find what didn't add upp, @Earlopain? Update: BUT THEY ONLY FAILED LOCALLY?!

When this is done:

Fixes #422

Earlopain commented 6 months ago

I was writing a whole thing here but someone already went through the trouble in #417

santiagorodriguez96 commented 6 months ago

Hi @olleolleolle! Good catch! Thank you for opening another PR for addressing this 🙂

Out of curiosity: is there a reason why you decided to remove the development dependency this time?

Regarding the failing tests:

@Earlopain got it right, the same is happening for me on local machine. If you have more info about the error that you consider might be relevant, please let us know on that issue 🙂

olleolleolle commented 6 months ago

@santiagorodriguez96 Oh, I was just being thorough, one-track minded. It can of course be used as a development dependency.

olleolleolle commented 6 months ago

Absolutely, I'll poke at making a module, it'll happen in this PR.