cedardevs / feedback

An issue-only repository for centralizing all external feedback
0 stars 0 forks source link

Modify the data access link label for the OER granule metadata #1

Closed Yuanjie0913 closed 4 years ago

Yuanjie0913 commented 5 years ago

In the data access links for the OER granule metadata, the direct link for the low resolution files is mentioned as 'Unknown'. The link works fine though. Can this be changed to something like 'Preview'? e.g. https://data.noaa.gov/onestop/#/collections/granules/AWbw8ZJ0HtVRBOAZkCRD

zebdelk commented 5 years ago

There are two parts to this.

  1. From what I can see of the underlying data, the metadata for that link is missing both name and description attributes. Updating that metadata would be the best way to change the text of the link.

  2. Production is on version 2.0.4, which doesn't recognize the protocol video:mp4. "Unknown" is the default we use for when we do not have specific rules for rendering a protocol. This is already fixed in version 2.1, which correctly identifies that protocol and labels it "Video" (assuming no link name or description is provided).

dneufeldcu commented 5 years ago

An example video record displayed in version 2.1 with linkProtocol set to "video:mp4" link

Yuanjie0913 commented 5 years ago

Thanks! Looks good. When will this version be merged to the production?

dneufeldcu commented 5 years ago

I estimate 2-4 weeks.

dneufeldcu commented 4 years ago

Fixed and in production as of v2.1.2