cedardevs / onestop

OneStop is a data discovery system being built by CIRES researchers on a grant from the NOAA National Centers for Environmental Information. We welcome contributions from the community!
GNU General Public License v2.0
42 stars 20 forks source link

Compatibility fixes for updated cloud deployment #1531

Closed mcquinne closed 1 year ago

mcquinne commented 1 year ago

Upon attempting the deploy the recent 3.0.0-RC4 images into a dev environment using the updated 7.17 Elastic stack, I encountered the following issues, which this branch aims to resolve:

  1. Helm chart updates have not been re-published as new chart version. Specifically, I tried to install the 3.0.0-beta version of the chart and it failed if I had any autoscaler.enabled: true present due to using an old HPA api version
  2. The onestop-search 3.0.0-RC4 image that was tagged on 8/5 produces containers that do not run. It has an issue in the gradle build related to trying to support both war and jar artifacts. The war plugin combined with the distroless java base image results in a container entrypoint of just java -jar with no arguments, which fails to run.
mcquinne commented 1 year ago

re: item 2 - the on-prem IT team indicated that it would be easier for them moving forward to be using executable jars for all microservices (search is the only service with the war plugin installed currently, including the other API applications registry and gateway). So for now I've moved forward by revering back to only building jars.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1531 (4bbc155) into master (738d697) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1531   +/-   ##
=========================================
  Coverage     56.13%   56.13%           
  Complexity      788      788           
=========================================
  Files           347      347           
  Lines         10295    10295           
  Branches       1167     1167           
=========================================
  Hits           5779     5779           
  Misses         4043     4043           
  Partials        473      473           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mcquinne commented 1 year ago

PR Status:

  1. Helm charts:
    • Switched to autoscaler/v2beta2 for compatibility with current range of EKS versions (1.20-1.24+)
    • Turned ingressClassName into a configurable value to avoid hard-coding
    • Repackaged chart and pubished as 3.0.0-beta2
  2. Search API build:
    • Removed war plugin/build artifact
    • Using jar-based container image like all the microservices

I've verified that these changes can be deployed into EKS and that the entire system is functional.