search

cedaro / grunt-wp-i18n

Internationalize WordPress themes and plugins with Grunt.
MIT License
160 stars 25 forks source link

Add unit test for themes with custom headers #13

Closed GaryJones closed 10 years ago

GaryJones commented 10 years ago

Similar to the unit test for plugins with custom headers.

I've got an issue where the processPot callback isn't being called for a theme I'm trying to generate a .pot for. The .pot uses the default headers. Wrote this unit test to try and debug an issue, but it passes fine, so I'm not sure what the problem is with my project.

bradyvercher commented 10 years ago

Hmm, is your callback returning the pot variable? Otherwise, it sounds it could be a race condition or the process may be returning an exit code that isn't 0: https://github.com/blazersix/grunt-wp-i18n/blob/develop/tasks/makepot.js#L112

GaryJones commented 10 years ago

Sorry, forgot to clarify this - after 2 hours I realized that somehow I'd got a version from over 2 months ago (even though I only started this project a week ago) that didn't yet have the callback feature. Did an npm update which grabbed the latest version and it all worked first time.

bradyvercher commented 10 years ago

No problem, glad you got it worked out :+1: